ENH: adding async mode to IRSA TAP based queries#3201
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
==========================================
- Coverage 68.32% 68.31% -0.01%
==========================================
Files 231 231
Lines 19197 19199 +2
==========================================
Hits 13116 13116
- Misses 6081 6083 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6f46ed4 to
5fa6406
Compare
5fa6406 to
29ba772
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
query_tapandquery_regionhas the newasync_modebool kwarg.I was testing with the query listed in astropy/pyvo#629 which times out with the sync mode, but works as expected and fast! with async. I don't really understand why this latter behaviour, but it doesn't matter much either as we leave it to the user to decide which mode to use rather than building in a heuristic in astroquery.
Closes #3143
Prior discussion about changing the API approach from the duplication of methods and favouring a keyword based future: #2598