Fix issue 3007: offline tests should be valid#3202
Merged
Conversation
Member
|
CI failures are related |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3202 +/- ##
==========================================
- Coverage 68.34% 68.34% -0.01%
==========================================
Files 231 231
Lines 19190 19192 +2
==========================================
+ Hits 13116 13117 +1
- Misses 6074 6075 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
approved these changes
Feb 12, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
Now this all looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the test data to filenames that match what's actually used in the query. It fixes #3007.