docs: add a clear message uppon ban#3225
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3225 +/- ##
==========================================
- Coverage 68.69% 68.69% -0.01%
==========================================
Files 231 231
Lines 19214 19216 +2
==========================================
+ Hits 13199 13200 +1
- Misses 6015 6016 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a906496 to
822412b
Compare
bsipocz
approved these changes
Feb 24, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
Minor wordsmithing, but otherwise looks all good. Thanks!
822412b to
c297de9
Compare
Member
Author
|
This is ready for merging, I applied your language corrections and asked XMatch's maintainer to validate the message 🙂 |
keflavich
approved these changes
Feb 25, 2025
Co-authored-by: Adam Ginsburg <keflavich@gmail.com>
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi astroquery's devs 🙂
An abusive XMatch user with astroquery's user agent was banned from our servers today. This made me realize that there are no warnings nor explanations in the documentation about DDoS attacks in this module.
Our support email is also added to the error message and to the documentation so that we can un-ban the astronomers after helping improving their workflows.
The section in the documentation can be removed when there will be a new release, as people won't see the 403: Forbidden error anymore.