Skip to content

Euclid: PR for issue #3226#3227

Merged
bsipocz merged 2 commits into
astropy:mainfrom
esdc-esac-esa-int:ESA_euclid_creates_temp_directory_in_the_repo
Feb 27, 2025
Merged

Euclid: PR for issue #3226#3227
bsipocz merged 2 commits into
astropy:mainfrom
esdc-esac-esa-int:ESA_euclid_creates_temp_directory_in_the_repo

Conversation

@cosmoJFH

Copy link
Copy Markdown
Contributor

This is the PR for the issue BUG: esa.euclid module creates temp directory in the repo during the tests #3226

@codecov

codecov Bot commented Feb 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.08%. Comparing base (edd8976) to head (1f45a44).
Report is 232 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   69.07%   69.08%   +0.01%     
==========================================
  Files         232      232              
  Lines       19592    19592              
==========================================
+ Hits        13534    13536       +2     
+ Misses       6058     6056       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this works!

I added a little bit of explanations for the changelog (I really need to add that to the devdocs), but will merge this as is and will clean-up at release time. Thanks.

Comment thread CHANGES.rst
Comment on lines +17 to +18
- Tests remove temp directories. [#3226]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for changelog entry here for multiple reasons: 1) we don't changelog internal (user invisible), docs, or test changes 2) the PR it follows up is not yet released, so these changes are "affect-dev". If there are new functionality added we may just list the PR number under the previous entry.

@bsipocz bsipocz merged commit db6b28c into astropy:main Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: esa.euclid module creates temp directory in the repo during the tests

2 participants