Skip to content

GAIA: Revert change in the name of the datalink RVS type, in the PR #3207#3238

Merged
bsipocz merged 2 commits into
astropy:mainfrom
esdc-esac-esa-int:ESA_gaia_GAIAMNGT-1828_ammend_change_rvs_type
Mar 3, 2025
Merged

GAIA: Revert change in the name of the datalink RVS type, in the PR #3207#3238
bsipocz merged 2 commits into
astropy:mainfrom
esdc-esac-esa-int:ESA_gaia_GAIAMNGT-1828_ammend_change_rvs_type

Conversation

@cosmoJFH

@cosmoJFH cosmoJFH commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

In PR #3207 we changed the name of the datalink retrieve type RVS by RVS_MEAN_SPECTRUM. We would like to revert this change. The rests of the changes done in the PR #3207 were right.

cc @esdc-esac-esa-int

jira:GAIAMNGT-1828)

@codecov

codecov Bot commented Mar 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.07%. Comparing base (8c84b28) to head (269a520).
Report is 310 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3238   +/-   ##
=======================================
  Coverage   69.07%   69.07%           
=======================================
  Files         232      232           
  Lines       19617    19617           
=======================================
  Hits        13551    13551           
  Misses       6066     6066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bsipocz bsipocz added the gaia label Mar 3, 2025
@bsipocz bsipocz added this to the v0.4.10 milestone Mar 3, 2025
@bsipocz bsipocz merged commit 53f16a9 into astropy:main Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants