[SIMBAD] Fix upstream changes#3258
Merged
Merged
Conversation
…marks and the datatype of biblio is now VARCHAR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 232 232
Lines 19637 19637
=======================================
Hits 13568 13568
Misses 6069 6069 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Mar 17, 2025
Member
Author
|
This also adds the new measurement table mesOtype into the documentation graph |
bsipocz
approved these changes
Mar 17, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
Thanks! No need for changelog for anything test/docs related or things that are only internal refactoring with no user-facing consequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIMBAD upgraded VOLLT today. This includes the fix from gmantele/vollt@407753f that was expected to break some of the examples (see the comments that are now removed)
The new version also makes SIMBAD's columns names respect the ADQL reserved keywords, this appears in the table
bibliowhere the columnyearis now protected by quotation marks.PS: I'm not sure about weather this needs a changelog entry or not? The changes are not from astroquery and only appear in the docs