ENH: adding Irsa.list_columns#3265
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 69.08% 69.05% -0.04%
==========================================
Files 232 232
Lines 19639 19652 +13
==========================================
+ Hits 13568 13570 +2
- Misses 6071 6082 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to list the columns of a given catalog.
I've done it to be similar to list_catalogs, and return a dict of name: description pairs rather than a table with two columns, but I'm happy to change it to return a table instead. (but then we should probably do the same for list_catalogs, too)
The obvious advantage I see for the dict approach is then there is no default ellipsis added, all the columns are listed out on the screen.
This is to close #3177
I'm adding docs and tests while waiting for the review.