Skip to content

MAINT: deprecate band from Gaia.load_data()#3278

Merged
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:MAINT_gaia_deprecate_band
Apr 23, 2025
Merged

MAINT: deprecate band from Gaia.load_data()#3278
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:MAINT_gaia_deprecate_band

Conversation

@bsipocz

@bsipocz bsipocz commented Mar 29, 2025

Copy link
Copy Markdown
Member

It has no effect on upstream query any more, thus we should remove it (but with a deprecation, so it doesn't break user code straight away).

Closes #3248

@bsipocz bsipocz added the gaia label Mar 29, 2025
@bsipocz bsipocz added this to the v0.4.11 milestone Mar 29, 2025
@bsipocz bsipocz requested a review from jespinosaar March 29, 2025 00:58
@codecov

codecov Bot commented Mar 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (af2d6f4) to head (f021816).
Report is 184 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3278   +/-   ##
=======================================
  Coverage   69.37%   69.38%           
=======================================
  Files         232      232           
  Lines       19686    19682    -4     
=======================================
- Hits        13657    13656    -1     
+ Misses       6029     6026    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz merged commit 023975b into astropy:main Apr 23, 2025
@bsipocz bsipocz deleted the MAINT_gaia_deprecate_band branch April 23, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAINT: deprecate band parameter for gaia

1 participant