Changed visual to have mpl kwargs for Alma#3285
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
==========================================
- Coverage 69.38% 69.37% -0.01%
==========================================
Files 232 232
Lines 19682 19689 +7
==========================================
+ Hits 13656 13659 +3
- Misses 6026 6030 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
approved these changes
Apr 8, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
Looks good with a minor fix for a namespace. I commit that directly so this can go in once CI is clean.
Member
|
Thank you @SpacialTree for the fix, and congrats on your first contribution to astroquery. I hope to see more of these in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion of the bug preventing regions queried from ALMA in Issue #3283, this pull request fixes the bug by changing
visualto have keywords that work with matplotlib.