Log a warning if a cached file's length cannot be verified#3290
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
- Coverage 69.37% 69.36% -0.02%
==========================================
Files 232 232
Lines 19689 19692 +3
==========================================
Hits 13659 13659
- Misses 6030 6033 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Apr 14, 2025
keflavich
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for implementing this (and the test!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this discussion.
Rather than raise an error when a cached file's length cannot be verified, warn the user and re-download the file. This is needed for certain files in the MAST Archive that are generated dynamically and don't include a
Content-Lengthheader in their response at this time.My understanding was that this could not be tested in
test_query.py, but I did add a case in the MAST module tests.