[SIMBAD] add async_job option in all queries#3305
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
==========================================
+ Coverage 69.82% 69.88% +0.05%
==========================================
Files 232 232
Lines 19711 19757 +46
==========================================
+ Hits 13764 13807 +43
- Misses 5947 5950 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
217045a to
ad94308
Compare
keflavich
approved these changes
Apr 28, 2025
keflavich
left a comment
Contributor
There was a problem hiding this comment.
lgtm, I have side conversation questions.
bsipocz
approved these changes
Apr 29, 2025
50d397a to
e612045
Compare
e612045 to
f1ee46b
Compare
bsipocz
approved these changes
May 5, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
Thank you @ManonMarchand.
Failures are unrelated and have been fixed in main already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #3205
It adds the possibility to launch SIMBAD queries in asynchronous mode. This mode allows to take
timeoutin account (this translates intoexecutionDurationin the VOSI async standard).