Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.07%. Comparing base (c522e2a) to head (da4e32a).
⚠️ Report is 124 commits behind head on main.

@@           Coverage Diff           @@
##             main    #3371   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         232      232           
  Lines       19893    19893           
=======================================
  Hits        13940    13940           
  Misses       5953     5953           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dear @bsipocz we have found a minor issue in the last commit (a missing comma in the list of retrieve types). Should we open a new pull request?

Ouch, I should not have just looked at it and merged.

Yes, please open a follow up PR

Puzzling how/why this wasn't picked up on with the style checker 😒

I guess the style checker allows for strings to be split on multiple lines without warning?

After reading the documentation

https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation

, it looks like the strings were concatenated.

Yes, syntactically that's what happened; we use this feature of python strings throughout the code base. It seems like a hard-to-see corner case that a style checker could catch, but since they're already primed to complain about too-long lines, they don't remark on it.

Ahh, yes, I suppose you're right as it all was in a list. Then there is no other solution but avoiding doing reviews as a multitask activity while at SciPy :)