Check that a column does not exist before adding to result table#3400
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3400 +/- ##
==========================================
+ Coverage 70.48% 70.51% +0.02%
==========================================
Files 232 232
Lines 19977 19997 +20
==========================================
+ Hits 14080 14100 +20
Misses 5897 5897 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
approved these changes
Sep 9, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
Thanks, all tests are green now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3399
This bug is actually due to a duplicated column in the response from our Roman search endpoint in the test environment. Others are making that fix, but I've also added checks here so that duplicated columns are not added to the output table.