Skip to content

Patch to solve issue #3282 (MiriadeClass)#3462

Closed
bcarry wants to merge 10 commits into
astropy:mainfrom
bcarry:main
Closed

Patch to solve issue #3282 (MiriadeClass)#3462
bcarry wants to merge 10 commits into
astropy:mainfrom
bcarry:main

Conversation

@bcarry

@bcarry bcarry commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

IMCCE base URL was changed from
http://vo.imcce.fr
to
https://ssp.imcce.fr

The columns from the Miriade/ephemcc service have changed on the new server, and the documentation adapted

@bsipocz bsipocz added this to the 0.4.12 milestone Nov 21, 2025
@bsipocz

bsipocz commented Nov 21, 2025

Copy link
Copy Markdown
Member

Many of these are already done in #3286, but that PR got stuck on upstream issues.

@bcarry bcarry marked this pull request as draft November 21, 2025 16:51
@bcarry

bcarry commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

the automatic checks are failing, but I don't see what can I do for these.
Any ideas? Help please :-)
Thanks

@bcarry bcarry marked this pull request as ready for review November 24, 2025 13:45
@mkelley

mkelley commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@bcarry it looks like a few issues. You can follow the links on each check to see a log of the tests which should help identify the failures:

  • Edit CHANGES.rst to include a summary of these changes following the format of the other entries.
  • Remove the whitespace on line 397 of core.py: astroquery/imcce/core.py:397:1: W293 blank line contains whitespace
  • Line 316 of core.py is trying to rename a "date" column to "epoch", but "date" does not exist.

@bcarry

bcarry commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @mkelley !

  • white space removed
  • info added on CHANGE.rst (my bad for not having done it)
  • I don't understand the date->epoch point:

@mkelley

mkelley commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Ah, it is the offline tests that are failing in astroquery/imcce/tests/test_miriade.py. They rely on the votable files in astroquery/imcce/tests/data Can you regenerate these files with the new service? They look like they were generated for 3552 for a single date, only varying coordtype according to the file name. The date doesn't seem to matter to the tests.

@bcarry

bcarry commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

Hi @mkelley
Sorry it took so long to push these files.
NB:

  • the VOTable have changed a bit
  • tcoor 6 is no longer provided by the service
    Thanks!

@mkelley

mkelley commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

OK, just updating the files wasn't enough, but I've edited the tests and documentation to address the remaining issues. @bcarry I cannot push the changes to your branch, but I have made a pull request on it. bcarry#1 I also looked at @bsipocz 's changes in #3286, and I cherry picked some of her changes (but I didn't look into the skybot issues).

@bsipocz

bsipocz commented Jan 15, 2026

Copy link
Copy Markdown
Member

OK, we're getting closer. The devdeps job's failure is unrelated, but I'm afraid the rest still have some relevance (besides the RTD failure which may be resolved with a rebase)

@bcarry

bcarry commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Hi all,
I'm pinging you on this issue. I think now this PR is 100s of commit behind, so I don;t know how complex it will be to merge. But we need to puh the URL changes etc into the main, as on the service side the old url is decommissioned
Thanks

@mkelley

mkelley commented May 1, 2026

Copy link
Copy Markdown
Contributor

@bsipocz Could you rerun the tests so @bcarry can see the current failures?

@mkelley

mkelley commented May 18, 2026

Copy link
Copy Markdown
Contributor

@bcarry I've tried to make some fixes for you. Running tox -e codestyle to find the code style errors, which I think I've addressed. I also added the pull request number to your change log entries, which should address that problem. However, I also rebased to update on the main branch, and I'm concerned that is going to cause headaches: I started to make a pull request on your main branch, but all the astroquery/main updates were being listed as commits. I don't think that's what we want, so I've made a new PR: #3595.

@bcarry

bcarry commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @mkelley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants