fix(run download): support non-zipped artifacts#13636
Open
AruneshDwivedi wants to merge 1 commit into
Open
Conversation
Artifacts uploaded with archive: false are returned with Content-Type application/octet-stream instead of application/zip. The download command previously tried to unzip all artifacts, causing 'zip: not a valid zip file' errors. Fix: check Content-Type header before attempting zip extraction. Non-zipped artifacts are saved directly using the artifact name. Fixes cli#13012 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13012
Artifacts uploaded with
archive: falseare returned withContent-Type: application/octet-streaminstead ofapplication/zip. Thegh run downloadcommand previously tried to unzip all artifacts, causingzip: not a valid zip fileerrors for non-zipped artifacts.Changes
Content-Typeresponse header before attempting zip extractionDownloadWithNamemethod to theplatforminterfaceTesting
Test_Download_NonZiptest that mocks a non-zipped response and verifies the file is saved directly