Skip to content

Remove duplicated PRs from GitHub API response.#594

Merged
mislav merged 4 commits into
cli:masterfrom
alissonbrunosa:pr-list-remove-duplicates
Mar 5, 2020
Merged

Remove duplicated PRs from GitHub API response.#594
mislav merged 4 commits into
cli:masterfrom
alissonbrunosa:pr-list-remove-duplicates

Conversation

@alissonbrunosa

Copy link
Copy Markdown
Contributor

Fixes #592

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the fix! This looks good, but I think extra precaution needs to be taken for this workaround to play well with limiting and pagination.

Comment thread api/queries_pr.go Outdated
@alissonbrunosa alissonbrunosa force-pushed the pr-list-remove-duplicates branch from a701bc4 to 101d985 Compare March 5, 2020 17:10
Comment thread api/queries_pr.go Outdated

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you 🙇

@mislav mislav merged commit ca7a936 into cli:master Mar 5, 2020
@alissonbrunosa alissonbrunosa deleted the pr-list-remove-duplicates branch March 5, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pr list command with multiple labels shows duplicated PR

2 participants