Ensure pr create validates all inputs before forking+pushing#618
Merged
Conversation
This avoids fork or push operation if there were errors processing the input arguments or if the operation has been cancelled during interactive survey.
Since we cannot pass the "draft" option as query parameter, this raises an error instead of proceeding to open the browser and potentially confuse the user as to why `--draft` wasn't respected.
vilmibm
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are any errors related to user input, or if the PR create operation has been cancelled via the interactive survey, avoid forking the repo or pushing the branch.
The diff might seem large, but this only swaps the old implemenation around.
Fixes #482, fixes #558, closes #615