Skip to content

switch {pr,issue} view default#665

Merged
vilmibm merged 3 commits into
masterfrom
preview-default
Mar 25, 2020
Merged

switch {pr,issue} view default#665
vilmibm merged 3 commits into
masterfrom
preview-default

Conversation

@vilmibm

@vilmibm vilmibm commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Summary

closes #555

Switches issue, pr view to print to the terminal by default and take --web/-w to open issue/pr
in browser.

@vilmibm vilmibm requested a review from mislav March 17, 2020 22:08
@vilmibm vilmibm changed the title preview default switch {pr,issue} view default Mar 17, 2020

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good!

If we wanted to keep backwards compatibility with existing usages of issue/pr view -p, we could potentially keep the flag as supported, mark it as hidden from the docs, and have it be a no-op. However, since we're in beta, I have no issue with breaking backwards compatibility here. 👍

@vs-jawad

vs-jawad commented Apr 1, 2020

Copy link
Copy Markdown

@mislav I disagree with this change and it did break existing workflows. More than that though, this should not have come out as a patch release, breaking existing functionality (even if you're in beta) should at least be a minor point release.

@mislav mislav deleted the preview-default branch April 2, 2020 07:05
@mislav

mislav commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

@vs-jawad I'm sorry for the trouble. I agree that this should have not been a patch release due to this change. We're going to try to bump the minor version number for changes like these in the future. However, please note that this software is in beta and will be subject to many more changes until it can be considered "stable". Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap default behavior of "view" actions to display in terminal instead of web

3 participants