Use remote tracking branch for base when detecting commits for pr create#717
Merged
Conversation
…eate` This is to avoid errors when a local base branch is missing or out of date.
This code was put in place in preparation for a feature that never shipped. Namely, we wanted to use the commit hash for the base branch so we can get an accurate `git log` involving the changes in a pull request. However, getting the commit hash from API is not the way to go because the latest commit might not be available in the person's local repository, and using a local tracking branch for base such as `origin/master` works quite well in most cases without dereferencing it.
vilmibm
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid errors when a local base branch is missing or out of date.
Fixes #710, closes #713