Add gh issue close <urlOrNumber>#843
Merged
probablycorey merged 14 commits intoApr 29, 2020
Merged
Conversation
Add test for closing issue Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
|
Woo this looks great! 2 thoughts:
|
Contributor
Author
|
@ampinsk Made those changes. The red checkmark both seems correct and incorrect, but so does the green checkmark. So I say lets try it out. |
vilmibm
suggested changes
Apr 29, 2020
vilmibm
left a comment
Contributor
There was a problem hiding this comment.
👍 i'm just being nitpicky about testing
| if !strings.Contains(err.Error(), "issues disabled") { | ||
| t.Fatalf("got unexpected error: %s", err) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
maybe a third test for the already closed state
| @@ -0,0 +1 @@ | |||
| { "id": "hi" } | |||
Contributor
There was a problem hiding this comment.
i think it would be fine to inline this? it's tiny and only used once. you can do:
http.StubResponse(200, bytes.NewBufferString(`{"id": "hi"}`))
Contributor
Author
There was a problem hiding this comment.
Very good point...
Contributor
Author
|
@vilmibm I've got the changes you requested in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
gh issue close <issue number or url>. If it is already closed it outputs a warning. If the repo doesn't allow issues, then it results in an error.Below is an AMAZING screenshot of it it in action!
#413