Add bracket_spacing rule#26
Closed
danielbayley wants to merge 1 commit into
Closed
Conversation
Member
|
Currently the way to build the documentation website is broken so I am trying to fix that before we add too many rules. |
1a0f3d4 to
28d8011
Compare
fb5c690 to
8edf325
Compare
Based on the [`braces_spacing`](https://github.com/aminland/coffeelint2/blob/master/src/rules/braces_spacing.coffee) rule. Closes aminland/coffeelint2#6.
Member
|
@danielbayley what is your opinion about adding rules to coffeelint vs telling users to create 3rd party rules? |
Member
Author
@UziTech I think obscure rules should be left for 3rd parties. But if the rule has an ESLint equivalent, then it should go in this repo… |
Member
|
Could you rebase this? Then I think it is ready to go 🚀 |
Member
|
I rebased and merged this in e0bc8b7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the
braces_spacingrule. Closes aminland/coffeelint2#6.