refactor: reuse code in both random and dataset benchmarking#310
Closed
alaeddine-13 wants to merge 18 commits into
Closed
refactor: reuse code in both random and dataset benchmarking#310alaeddine-13 wants to merge 18 commits into
alaeddine-13 wants to merge 18 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## feat-benchmark-sift #310 +/- ##
=======================================================
+ Coverage 86.29% 86.36% +0.07%
=======================================================
Files 134 134
Lines 6312 6287 -25
=======================================================
- Hits 5447 5430 -17
+ Misses 865 857 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
build(hanxiao): rolling out fix
build(hanxiao): rolling out fix
* fix: del remove attribute * test: add test that covers fix
build(hanxiao): rolling out fix
build(hanxiao): rolling out fix
JoanFM
requested changes
May 11, 2022
JoanFM
left a comment
Member
There was a problem hiding this comment.
Please rebase this PR so that it does not show unwanted changes
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: