chore: split tests with older proto version#567
Conversation
Codecov Report
@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 88.28% 88.23% -0.06%
==========================================
Files 134 133 -1
Lines 6640 6585 -55
==========================================
- Hits 5862 5810 -52
+ Misses 778 775 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aa1b795 to
f7f623b
Compare
|
Any news regarding this? It would be very helpful for team-now. |
We are looking at some issues to fix the tests because of some protobuf dependency problem between qdrant and paddle paddle |
…upgrade-qdrant-client
ca8bce3 to
56c8296
Compare
2fa10c7 to
0ee4d5e
Compare
|
📝 Docs are deployed on https://ft-feat-upgrade-qdrant-client--jina-docs.netlify.app 🎉 |
…upgrade-qdrant-client
33b8d92 to
2a3b74d
Compare
|
I would prefer entirely moving tests (even maybe test files) that contain tf/paddlepaddle, rather than copying test code |
| fail_ci_if_error: false | ||
| token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos | ||
|
|
||
| docarray-oldproto-test: |
There was a problem hiding this comment.
let's always reference old proto to protobuf 3 and new proto is protobuf 4
There was a problem hiding this comment.
I would let the pip dependency solution do the job, I do not want to say it here
| #declare -a array1=( "tests/unit/test_*.py" ) | ||
| #declare -a array2=( $(ls -d tests/unit/*/ | grep -v '__pycache__' | grep -v 'array') ) | ||
| #declare -a array3=( "tests/unit/array/*.py" ) |
There was a problem hiding this comment.
I think it's fine to keep placeholder code for future
dc82e06 to
1fa4772
Compare
1fa4772 to
e91a9ee
Compare
…upgrade-qdrant-client
Signed-off-by: Joan Fontanals <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals <joan.martinez@jina.ai>
Codecov ReportBase: 88.29% // Head: 88.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 88.29% 88.01% -0.28%
==========================================
Files 134 133 -1
Lines 6648 6585 -63
==========================================
- Hits 5870 5796 -74
- Misses 778 789 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Please @AnneYang720 , @alaeddine-13 reopen PR on your own |
Goals:
Refactor the tests so that
tensorflowandpaddlecan work with a specificprotobufversion