chore: bump annlite version#676
Conversation
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 88.28% 88.02% -0.26%
==========================================
Files 134 134
Lines 6640 6648 +8
==========================================
- Hits 5862 5852 -10
- Misses 778 796 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| ], | ||
| 'annlite': [ | ||
| 'annlite==0.3.13', | ||
| 'annlite', |
There was a problem hiding this comment.
set correct mimimum version here
| 'transformers>=4.16.2', | ||
| 'weaviate-client~=3.3.0', | ||
| 'annlite>=0.3.12', | ||
| 'annlite', |
There was a problem hiding this comment.
set correct mimimum version here
| **kwargs, | ||
| ): | ||
|
|
||
| config = copy.deepcopy(config) |
There was a problem hiding this comment.
why deepcopy here? the data_path doesn't change
There was a problem hiding this comment.
we need it because in some cases you pass the same config object to multiple das. So even though data_path is randomly generated for some DA, it will be re-used for the next one, implicitly.
That's why I try to enforce the same pattern for all backends to avoid this kind of issues
| del subindex_da[old_ids] | ||
| subindex_da.extend(DocumentArray(docs)[subindex_selector]) | ||
| del subindex_da[old_ids] | ||
| subindex_da.extend(DocumentArray(docs)[subindex_selector]) |
There was a problem hiding this comment.
this is problematic for annlite. But in general I think subindices should be synced when the parent index is synced
There was a problem hiding this comment.
but why not use the context manager?
2da9f92 to
53b1048
Compare
Goals:
Bump ANNLite version to see what breaks