Skip to content

ci: fix first time build issue on build old docs#684

Merged
JoanFM merged 1 commit into
mainfrom
fix-first-build-issue
Oct 25, 2022
Merged

ci: fix first time build issue on build old docs#684
JoanFM merged 1 commit into
mainfrom
fix-first-build-issue

Conversation

@Jackmin801

@Jackmin801 Jackmin801 commented Oct 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Goals:

  • Patch issue in failing workflow https://github.com/jina-ai/docarray/actions/runs/3320394868
  • The issue is due to it being the first time versioned documentation is being added
  • The _versions.json file does not exist yet, so the remove command intended to remove the old _versions.json fails
  • A condition was added to the line so that failure to remove the old _versions.json are ignored (since there might not be an old one)

@Jackmin801 Jackmin801 requested a review from JoanFM October 25, 2022 11:34
@JoanFM JoanFM marked this pull request as ready for review October 25, 2022 11:35
@JoanFM JoanFM merged commit 41d8998 into main Oct 25, 2022
@JoanFM JoanFM deleted the fix-first-build-issue branch October 25, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees

No one assigned

Labels

area/cicd area/housekeeping size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jackmin801 @JoanFM