feat: add login logout proxy methods#697
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 88.10% 88.08% -0.02%
==========================================
Files 133 133
Lines 6538 6538
==========================================
- Hits 5760 5759 -1
- Misses 778 779 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
requested changes
Oct 27, 2022
| hubble.logout() | ||
|
|
||
|
|
||
| def notebook_login(force: bool = False): |
Member
There was a problem hiding this comment.
wait because hubble-sdk is working on a feature to autodetect it from notebook
NicholasDunham
suggested changes
Oct 27, 2022
NicholasDunham
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall; I made some minor wording changes. One usage note: login is a noun or adjective; log in is a verb.
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com> Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Member
Author
thanks for the feedback, I applied your suggestions |
NicholasDunham
approved these changes
Oct 27, 2022
Member
|
|
JohannesMessner
requested changes
Oct 31, 2022
alaeddine-13
commented
Oct 31, 2022
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Member
Author
I changed it with the cloud emoji |
NicholasDunham
suggested changes
Oct 31, 2022
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com> Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
…feat-login-logout
|
📝 Docs are deployed on https://ft-feat-login-logout--jina-docs.netlify.app 🎉 |
JohannesMessner
approved these changes
Nov 1, 2022
NicholasDunham
approved these changes
Nov 1, 2022
JoanFM
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add login/logout methods in order to clarify login procedure while using docarray
closes: #696
should be merged after jina-ai/jina-hubble-sdk#96