refactor: create enums for strings in dataclasses#704
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
==========================================
+ Coverage 85.95% 88.55% +2.59%
==========================================
Files 133 134 +1
Lines 6538 6555 +17
==========================================
+ Hits 5620 5805 +185
+ Misses 918 750 -168
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
264e73f to
dd2ee41
Compare
dd2ee41 to
ab0bbf2
Compare
JoanFM
requested changes
Oct 28, 2022
ab0bbf2 to
8a1038d
Compare
9c4fedd to
aa8b2f3
Compare
aa8b2f3 to
b853393
Compare
alaeddine-13
reviewed
Nov 1, 2022
alaeddine-13
approved these changes
Nov 1, 2022
JoanFM
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
_metadataand store globally #449