Skip to content

docs: add username to docarray pull#847

Merged
samsja merged 1 commit into
docarray:mainfrom
delgermurun:docs-add-username-docarray-pull
Nov 28, 2022
Merged

docs: add username to docarray pull#847
samsja merged 1 commit into
docarray:mainfrom
delgermurun:docs-add-username-docarray-pull

Conversation

@delgermurun

@delgermurun delgermurun commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Goals:

  • Adapt namespacing feature on docs
  • ...
  • check and update documentation, if required. See guide

@codecov-commenter

codecov-commenter commented Nov 25, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 59.97% // Head: 82.74% // Increases project coverage by +22.76% 🎉

Coverage data is based on head (579408c) compared to base (7ddbb87).
Patch has no changes to coverable lines.

❗ Current head 579408c differs from pull request most recent head 88de81e. Consider uploading reports for the commit 88de81e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #847       +/-   ##
===========================================
+ Coverage   59.97%   82.74%   +22.76%     
===========================================
  Files         138      138               
  Lines        7040     7040               
===========================================
+ Hits         4222     5825     +1603     
+ Misses       2818     1215     -1603
Flag Coverage Δ
docarray 82.74% <ø> (+22.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/proto/io/__init__.py 93.22% <0.00%> (+1.69%) ⬆️
docarray/document/mixins/_property.py 85.80% <0.00%> (+1.93%) ⬆️
docarray/document/pydantic_model.py 100.00% <0.00%> (+4.08%) ⬆️
docarray/score/data.py 100.00% <0.00%> (+4.54%) ⬆️
docarray/array/storage/memory/backend.py 100.00% <0.00%> (+5.00%) ⬆️
docarray/array/storage/qdrant/__init__.py 97.05% <0.00%> (+5.88%) ⬆️
docarray/array/mixins/match.py 91.66% <0.00%> (+8.33%) ⬆️
docarray/array/storage/memory/seqlike.py 94.28% <0.00%> (+8.57%) ⬆️
docarray/array/storage/sqlite/seqlike.py 62.22% <0.00%> (+8.88%) ⬆️
docarray/array/storage/elastic/backend.py 93.23% <0.00%> (+9.77%) ⬆️
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delgermurun delgermurun force-pushed the docs-add-username-docarray-pull branch from 579408c to 88de81e Compare November 25, 2022 10:26
samsja
samsja approved these changes Nov 28, 2022
View reviewed changes

@samsja samsja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samsja samsja enabled auto-merge (squash) November 28, 2022 10:49
@samsja samsja disabled auto-merge November 28, 2022 10:50
@samsja samsja merged commit 523dd61 into docarray:main Nov 28, 2022
@delgermurun delgermurun deleted the docs-add-username-docarray-pull branch November 28, 2022 10:53
guenthermi pushed a commit to guenthermi/docarray that referenced this pull request Nov 28, 2022
@delgermurun @guenthermi
docs: add username to docarray pull (docarray#847)
9dbabed
@alexcg1 alexcg1 mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsja samsja samsja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delgermurun @codecov-commenter @samsja