Fix: Do not block main process for async dialog#12404
Merged
codebytere merged 1 commit intoMar 22, 2018
Merged
Conversation
MarshallOfSound
approved these changes
Mar 22, 2018
Contributor
|
An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually |
Contributor
|
An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually |
Member
|
/trop run backport |
Contributor
|
The backport process for this PR has been manually initiated, here we go! :D |
Contributor
|
An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually |
Contributor
|
We have automatically backported this PR to "2-0-x", please check out #12407 |
Contributor
Author
|
@MarshallOfSound should I manually open a PR to |
Member
|
@sethlu that'd be great, thanks! |
sethlu
added a commit
to sethlu/electron
that referenced
this pull request
Mar 26, 2018
Contributor
|
Is it possible to test this? |
Contributor
Author
|
@YurySolovyov the original issue provides a test case for this. |
ckerr
pushed a commit
that referenced
this pull request
Mar 28, 2018
sethlu
added a commit
to sethlu/electron
that referenced
this pull request
May 3, 2018
This was referenced Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in #12368: Although the current API seems async
electron.dialog.show{Open,Save}Dialog()withcallbackprovided, it runs on a blocking call to macOS AppKit.Doc ref: