Focus webview directly in offscreen mode#12507
Merged
Merged
Conversation
codebytere
approved these changes
Apr 2, 2018
Member
|
@brenca Can you give a quick line about why this works, I might be missing something but it's not entirely obvious to me why focusing on a webview element would fix stuff not being focused in off screen mode. |
Contributor
Author
|
@MarshallOfSound It's mostly a naming issue, the |
Member
4154d5d to
b393690
Compare
zcbenz
approved these changes
Apr 5, 2018
sethlu
pushed a commit
to sethlu/electron
that referenced
this pull request
May 3, 2018
This was referenced Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12497