JavaScript: Add model of JSON parsers#8
Closed
asgerf wants to merge 3 commits into
Closed
Conversation
|
|
xiemaisi
reviewed
Aug 3, 2018
xiemaisi
left a comment
There was a problem hiding this comment.
LGTM.
Can you remind me whether you've profiled these changes already?
calumgrant
pushed a commit
to calumgrant/ql
that referenced
this pull request
Aug 3, 2018
JavaScript: Pull in changes from 26f4832ee48146367c88445114ec069982a72f33.
Contributor
Author
|
Will reopen in a sec. |
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Improve extractor build and add GitHub Actions configuration
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Kotlin: Various fixes for extracting kotlinc
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Add some changed-files sources
tausbn
added a commit
that referenced
this pull request
May 1, 2026
#8: Reject * after non-capture template groups with a compile error. Previously (foo (bar)*) silently dropped the *, behaving like (bar). #9: Verify inner token streams are exhausted after parsing query nodes. Unconsumed tokens inside a parenthesized group now produce a compile error. Fixed a test using the old redundant (pattern)* syntax inside a field*: group. #10: Use ast.get_root() instead of hardcoded 0 for the root node id in apply_rules calls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
JsonParserCallwhich models a call to a JSON parser.JsonParseCallto avoid confusion.JSON.parsehas been updated to includeJsonParserCall.NosqlInjectionquery used two-pass taint tracking to identify user-controlledJSON.parsecalls, and then use those as sources. This was redundant with the taint step throughJSON.parse, however. This has been removed, instead relying on the standard taint step. I've added a test to make sure it still works. In theory, some results may disappear since the two-step solution technically allowed for mismatched call/returns.