feat(memory): improve multi-part text handling in PreloadMemoryTool#375
Closed
kshitizz36 wants to merge 0 commit into
Closed
feat(memory): improve multi-part text handling in PreloadMemoryTool#375kshitizz36 wants to merge 0 commit into
kshitizz36 wants to merge 0 commit into
Conversation
Contributor
Author
|
@hangfei @boyangsvl PTAL |
Collaborator
|
@kshitizz36 thank you for the PR and sorry for the delay. We were busy with Google I/O and just catch up. Could you please resolve the conflicts first ? Thank you :) |
Contributor
Author
|
Hi @seanzhou1023 , |
7b64a5c to
dbdeb49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
PreloadMemoryToolclass to properly handle multiple text parts within memory events. The implementation now correctly joins text parts from each event to provide comprehensive context to the LLM.Changes
Implementation Details
The implementation now:
Testing
All tests are now passing with the updated implementation. The test suite covers:
This implementation focuses specifically on improving text part handling as requested in the review feedback.
#129