Skip to content

fix(rab): run async background boundary refresh on detached session #17441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbayati merged 20 commits into from
Jun 15, 2026
Merged

fix(rab): run async background boundary refresh on detached session #17441

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
dab0d4c
fix(rab): detach async transport session for background worker
nbayati Jun 12, 2026
fab83f1
test(auth): add unit tests for async transport clone and socket race …
nbayati Jun 12, 2026
3240f44
fix(auth): address gemini PR review comment and fix async rab refresh…
nbayati Jun 12, 2026
4312df8
fix(auth): address review comments for async RAB transport cloning an…
nbayati Jun 12, 2026
b36e583
fix(auth): preserve enterprise connection state in async transport cl…
nbayati Jun 12, 2026
d11fd64
make clone a private method
nbayati Jun 12, 2026
d203e75
refactor: extract RAB async request unwrapping into helpers and add u…
nbayati Jun 12, 2026
9eaed0b
refactor: add type annotations and suppress type checks for aiohttp s…
nbayati Jun 12, 2026
31404d7
address review comments
nbayati Jun 12, 2026
4a79bdd
fix mocking in failing unit test
nbayati Jun 12, 2026
74fcfac
add unit tests to regional access boundary utils
nbayati Jun 12, 2026
00ffcdb
fix(transport): fix resolver leak, Windows crash, and proxy errors in…
nbayati Jun 13, 2026
8153425
add unit tests to get full coverage on the new code paths
nbayati Jun 13, 2026
5e2fbc2
fix formatting issue
nbayati Jun 13, 2026
cef4bbc
fix: synchronously clone request transport to prevent ClientSession c…
nbayati Jun 15, 2026
6d0fd3a
docs: document limitations and errors in transport _clone docstrings
nbayati Jun 15, 2026
ebaa1d5
fix: support generic awaitables like Future in close_cloned_request c…
nbayati Jun 15, 2026
cae43cf
test: fix start_refresh_suppresses_request_clone_exception by asserti…
nbayati Jun 15, 2026
05ffb8a
fix: raise TransportError on closed transport calls in legacy aiohttp…
nbayati Jun 15, 2026
2d17e65
fix lint failure
nbayati Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix lint failure
  • Loading branch information
@nbayati
nbayati committed Jun 15, 2026
commit 2d17e653cef10f04370f6a3db4eb67c4fd713fdd
2 changes: 0 additions & 2 deletions packages/google-auth/tests_async/transport/test_aiohttp_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ async def test_close(self):
await request.close()
http.close.assert_awaited_once() # Still only called 1 time


@pytest.mark.asyncio
async def test_request_call_closed(self):
http = mock.create_autospec(
Expand All @@ -237,7 +236,6 @@ async def test_request_call_closed(self):
):
await request("http://example.com")


@pytest.mark.asyncio
async def test__clone_no_session(self):
request = aiohttp_requests.Request()
Expand Down
Loading