Skip to content

cleanup old rtl residue - do not apply direction to grid-stack-rtl#3269

Merged
adumesny merged 1 commit into
gridstack:masterfrom
danielgindi:rtl_cleanup
Jun 22, 2026
Merged

cleanup old rtl residue - do not apply direction to grid-stack-rtl#3269
adumesny merged 1 commit into
gridstack:masterfrom
danielgindi:rtl_cleanup

Conversation

@danielgindi

@danielgindi danielgindi commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Description

Minor cleanup. more fix #819

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

Comment thread src/gridstack.scss
}

.grid-stack-rtl {
direction: ltr;

@adumesny adumesny Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you don't want that set by default because ??? you're more knowlegable on this than me so I will defer this to you. Just trying to understand to make sure things work out of the box

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielgindi please explain

@adumesny

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

@danielgindi

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Done

@adumesny adumesny merged commit 7a8f311 into gridstack:master Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gridstack rtl mode

2 participants