Support defining Union inside a dataclass#1362
Merged
Merged
Conversation
certik
reviewed
Dec 15, 2022
| x: i32 | ||
| y: i64 | ||
| b: B | ||
| c: i32 |
Contributor
There was a problem hiding this comment.
Perfect! While at this, given the new StructStaticMember, can you also please add a test for:
@dataclass
class A:
@dataclass
class B(Union):
x: i32
y: i64
b: B
c: i32Essentially a "struct in struct"? We will need it too sooner or later, so now is the time to make sure it works.
Collaborator
Author
There was a problem hiding this comment.
Done. Please let me know if there is anything else to do here.
22760ba to
0232fb4
Compare
certik
approved these changes
Dec 23, 2022
certik
left a comment
Contributor
There was a problem hiding this comment.
I think this is fine. I haven't checked the verify() changes in detail, hopefully they are correct.
0232fb4 to
5a27552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.