Fix #80216: imap_mail_compose() does not validate types/encodings#6323
Closed
cmb69 wants to merge 1 commit into
Closed
Fix #80216: imap_mail_compose() does not validate types/encodings#6323cmb69 wants to merge 1 commit into
cmb69 wants to merge 1 commit into
Conversation
We need to check whether the given `type`s and `encoding`s are within bounds to avoid segfaults and out-of-bound reads.
nikic
approved these changes
Oct 12, 2020
Member
Presumably libc-client compiles using default visibility rather than |
Member
Author
|
Thanks! Then we should go with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to check whether the given
types andencodings are withinbounds to avoid segfaults and out-of-bound reads.
This is ugly. In order to detect whether the custom types and encodings are actually supported, we have to access the global
body_typesandbody_encodingswhich are declared in mail.h, but not be exported. There is no issue on Windows, because libc-client is linked statically (at least with the official dependencies), but otherwise this patch may not even build.