Fix rand_range32() for umax = UINT32_MAX#9416
Merged
Merged
Conversation
This was introduced in the commit that added the random extension: 4d8dd8d. Resolves phpGH-9415
zeriyoshi
approved these changes
Aug 24, 2022
zeriyoshi
left a comment
Contributor
There was a problem hiding this comment.
Embarrassing mistake. Thanks for the proper fix!
LGTM
cmb69
reviewed
Aug 24, 2022
cmb69
left a comment
Member
There was a problem hiding this comment.
Thank you! Looks good to me, except perhaps for the test case.
Member
|
OT, but since I've just noticed this: we need to address https://github.com/php/php-src/runs/7992692944?check_suite_focus=true#step:5:9. PS: #9417 |
Member
Author
Yes, I noticed that also. Is this caused by an update of libxml in homebrew? |
Member
Apparently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in the commit that added the random extension:
4d8dd8d.
Resolves GH-9415