Skip to content

feat(tray): added option to show tray icons sorted#3189

Open
anhnamtran wants to merge 1 commit into
polybar:masterfrom
NAndLib:sorted-tray
Open

feat(tray): added option to show tray icons sorted#3189
anhnamtran wants to merge 1 commit into
polybar:masterfrom
NAndLib:sorted-tray

Conversation

@anhnamtran

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

The new tray module current will render the tray icons in more or less arbitrary order. This change adds an option to the module to sort the icons by their WM_NAME.

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
    • A new configuration option is added to the tray module
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
    • A new configuration option is added to the tray module
  • Does not require documentation changes

The new tray module current will render the tray icons in more or less
arbitrary order. This change adds an option to the module to sort the
icons by their WM_NAME.
@anhnamtran anhnamtran marked this pull request as ready for review November 27, 2024 22:14
@codecov

codecov Bot commented Nov 27, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.65%. Comparing base (9476ad8) to head (ea34148).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/x11/tray_manager.cpp 0.00% 5 Missing ⚠️
src/x11/tray_client.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
- Coverage   12.66%   12.65%   -0.01%     
==========================================
  Files         160      160              
  Lines       12561    12568       +7     
==========================================
  Hits         1591     1591              
- Misses      10970    10977       +7     
Flag Coverage Δ
unittests 12.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant