Add parameter opt out for setinfo commands#1370
Conversation
7a83390 to
7f9fd68
Compare
okhoshi
left a comment
There was a problem hiding this comment.
Seems overkill to have 2 parameters to control this
|
Fix for #1347 (comment) |
Co-authored-by: Quentin D. <4972091+Okhoshi@users.noreply.github.com>
|
Trimmed the whitespace eclint complained about: |
|
Test coverage? |
|
Test added. You need to "Approve and run workflows" to trigger tests and get result from |
|
Redis 7 errors unrelated (might have been introduced by last week update of Redis 7.2) Can be verified with #1372 |
…dis into feature/setinfo-opt-out
|
No, why do we need client name/version to be configurable at all? It should always be Predis, no? |
|
@tillkruss I believe @chayim knows more than me about that. It looks like clients should be able to advertise their own products this way. F.E if magento uses predis as Redis client, they can override this values, so cloud instances can collect this kind of data about magento clients. |
|
The reason for allowing setting names and versions is to enable "whatever people want to create". It's entirely possible to build client solutions on top of existing clients (nredisstack and stackexchange.redis for example). This is the vision of how these things would be used. It also allows (same example) for a client to advertise something like: Thus, sharing all. |
|
@kylekatarnls: I'll merge a quick fix in #1399, because #1398 is making this more complicated. |
This gives an opt-out for users who don't need the bootstrap
SETINFOand want to remove them for performance or other reasons.