Skip to content

first commit#1

Merged
leeqvip merged 2 commits into
pycasbin:masterfrom
Agent-Hellboy:master
Jun 13, 2020
Merged

first commit#1
leeqvip merged 2 commits into
pycasbin:masterfrom
Agent-Hellboy:master

Conversation

@Agent-Hellboy

@Agent-Hellboy Agent-Hellboy commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Agent-Hellboy Agent-Hellboy reopened this Jun 10, 2020
@Agent-Hellboy

Agent-Hellboy commented Jun 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

hi there,
When I was preparing for a GSOC proposal I came across this repo. I found there is no activity since 2019. I thought nowadays everyone is using sqlalchemy that's why there is no commit since 2019. But the sqlobject is not archived yet it is actively maintained by its author having a commit in March 2020. I have tried my best to follow the structure of the casbin_sqlalchemy_adapter. If you guys approve this then I will implement API for remove_policy and remove_filtered_policy. I will also prepare the setup file and upload it to PyPI also.

@hsluoyz

hsluoyz commented Jun 10, 2020

Copy link
Copy Markdown
Member

@techoner please review.

@leeqvip leeqvip self-requested a review June 13, 2020 10:07
leeqvip
leeqvip requested changes Jun 13, 2020
View reviewed changes

@leeqvip leeqvip left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@princekrroshan01 Please format.

@leeqvip leeqvip merged commit bf936fa into pycasbin:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leeqvip leeqvip leeqvip requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Agent-Hellboy @hsluoyz @leeqvip