Upgrade dependencies and minor clean up#580
Merged
Merged
Conversation
- oz 4.9.3 - chainlink 2.7.1 - forge-std 1.7.3
- Rename confusing state variable to be more explicit - Remove unnecessary states and functions for deployment - Fix tests
There was a problem hiding this comment.
Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
+ Coverage 62.94% 63.87% +0.92%
==========================================
Files 215 215
Lines 6639 6627 -12
==========================================
+ Hits 4179 4233 +54
+ Misses 2460 2394 -66 ☔ View full report in Codecov by Sentry. |
nkrishang
approved these changes
Nov 23, 2023
kumaryash90
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up and keep our dependencies up-to-date. There are quite a number of unused files, will clean them up in a separate PR later.
Changes:
AirdropClaimablecontracts to rename confusing states name, remove redundant states, and fixed tests