Custom errors, etc#619
Merged
Merged
Conversation
| address _publisher | ||
| ) external view returns (CustomContractInstance[] memory published) { | ||
| CustomContractInstance[] memory linkedData = prevPublisher.getAllPublishedContracts(_publisher); | ||
| CustomContractInstance[] memory linkedData; |
Check warning
Code scanning / Slither
Uninitialized local variables
| string memory compilerMetadataUri | ||
| ) public view returns (string[] memory publishedMetadataUris) { | ||
| string[] memory linkedUris = prevPublisher.getPublishedUriFromCompilerUri(compilerMetadataUri); | ||
| string[] memory linkedUris; |
Check warning
Code scanning / Slither
Uninitialized local variables
| _publisher, | ||
| _contractId | ||
| ); | ||
| CustomContractInstance[] memory linkedVersions; |
Check warning
Code scanning / Slither
Uninitialized local variables
| _setupRole(DEFAULT_ADMIN_ROLE, _msgSender()); | ||
| constructor( | ||
| address _defaultAdmin, | ||
| address _trustedForwarder, |
Check notice
Code scanning / Slither
Local variable shadowing
Comment on lines
+32
to
+39
| function _efficientHash(bytes32 a, bytes32 b) private pure returns (bytes32 value) { | ||
| /// @solidity memory-safe-assembly | ||
| assembly { | ||
| mstore(0x00, a) | ||
| mstore(0x20, b) | ||
| value := keccak256(0x00, 0x40) | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 64.55% 64.73% +0.17%
==========================================
Files 216 216
Lines 6701 6700 -1
==========================================
+ Hits 4326 4337 +11
+ Misses 2375 2363 -12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.