Skip to content

Update wpmjson schema#241

Merged
thelovekesh merged 8 commits into
mainfrom
update/manifest-schema
Jun 5, 2026
Merged

Update wpmjson schema#241
thelovekesh merged 8 commits into
mainfrom
update/manifest-schema

Conversation

@thelovekesh

Copy link
Copy Markdown
Collaborator
  • Remove team and introduce author
  • Update validator for strict validation
  • Add test cases to test edge cases
  • Add json schema for wpm.json config file

@thelovekesh thelovekesh added the core changes made in cli core api label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

📦 wpm cli builds 📦

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the team field with a single author field, introduces dependency integrity validation (preventing self-dependencies and duplicate listings), caps dependencies at 16, and adds a new schema.json file. The review feedback highlights several alignment opportunities between the new JSON schema and the Go validator's constraints (such as string lengths, tag counts, and dependency limits). Additionally, it points out a validation discrepancy where version and type should be optional for private packages, and suggests improving self-dependency validation to report errors for both dependencies and devDependencies concurrently.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pkg/pm/wpmjson/wpmjson.go
Comment thread pkg/pm/wpmjson/validator/validator.go
Comment thread schema.json
Comment thread schema.json
Comment thread schema.json
Comment thread schema.json
Comment thread schema.json
Comment thread schema.json
Comment thread schema.json
Comment thread schema.json
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@thelovekesh thelovekesh merged commit 73798c3 into main Jun 5, 2026
17 checks passed
@thelovekesh thelovekesh deleted the update/manifest-schema branch June 5, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core changes made in cli core api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant