AST Bugfix: correctly parsing TypeNameContext - slice of types#183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this one was nasty. Basically what I did is went through parser.TypeNameContext and created 3 different nodes instead of one, resulting in types such as address[] being address only. This had issues later on with ABI and constructor and what not. Fixed it now.
Fixing this error cascading resulted in different error while doing the resolution of the reference ids. -> I had id incremented where it should not be resulting in a reference not being able to find itself.
Besides that, now due to the [] types, storage is a bit more buggy. Applied patch for tests to pass but storage itself needs fix.