fix: translate CMS item slugs on locale switch and links#341
Merged
Conversation
- Resolve translated folder/page/CMS slugs in the locale selector so switching language preserves the correct path (fixes #340) - Use the raw source slug as the default-locale value and per-locale fallback instead of the already-translated current-locale value - Translate referenced/ref dynamic-page link slugs to the active locale - Left-align the localizing element library to match the real library - Move "Manage locales" to the top of the header locale dropdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switching language on a dynamic CMS page now preserves the translated item slug instead of keeping the source-language one, and dynamic-page links resolve to the localized URL. Closes #340.
Changes
buildLocalizedPageUrlsutility that resolves translated folder/page/CMS slugs into relative URLs per localePageRenderer(only on multi-locale pages with a locale selector) and pass them toLocaleSelector, which now prefers them over naive prefix manipulationcollectionItemvalues are already translated)Test plan