fix: dedupe anchor ids in link settings dropdowns#351
Merged
Conversation
Two layers can share the same custom HTML id (e.g. duplicated component instances), so the anchor selection dropdown rendered duplicate options keyed by that id, triggering React duplicate-key warnings. Deduplicate by anchor id in findLayersWithAnchorId; an #id link resolves to the first match anyway, so each anchor only needs to appear once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting a link layer could log a React "two children with the same key" warning. The anchor selection dropdown lists every element with a custom HTML id and keyed each option by that id, so two layers sharing an id (e.g. duplicated component instances) produced duplicate keys.
Changes
findLayersWithAnchorId, fixing all anchor dropdowns (link settings, rich text link settings, collection link field input). An#idlink resolves to the first match, so each anchor only needs to appear once — this also removes confusing duplicate options.Test plan