fix: invalid DOM property warning for custom attributes#365
Merged
Conversation
Custom attributes stored in layer.settings.customAttributes were applied to React elements verbatim, so imported/migrated layers with lowercase HTML attributes (e.g. fetchpriority, crossorigin) triggered invalid DOM property warnings. Route them through the shared HTML_TO_REACT_ATTRS map, consolidating the previously duplicated per-renderer attribute maps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom attributes set on layers (stored in
layer.settings.customAttributes) were applied to React elements verbatim. Imported/migrated layers that stored attributes in lowercase HTML form (e.g.fetchpriority,crossorigin) triggered React's "Invalid DOM property" console warning and rendered as unrecognized props.Changes
customAttributesthrough the sharedHTML_TO_REACT_ATTRSmap in both renderers (element + iframe paths), convertingfetchpriority→fetchPriority,crossorigin→crossOrigin, etc.HTML_TO_REACT_ATTRSfromlib/parse-head-html.ts, removing the duplicated per-rendererhtmlToJsxAttrMapobjects.decoding) pass through untouched.Test plan
fetchpriorityattribute — no console warningcrossorigin,referrerpolicy,tabindexmap to their JSX equivalentsdecoding,loading) still render correctly