perf: speed up canvas loading for repeated collections#366
Merged
Conversation
Collection layer data was cached per layerId, so a collection repeated across many component instances (common with reference collections) fired one identical request per instance. On large collections these ran concurrently and saturated the event loop, making the canvas slow to load. Share one in-flight/resolved request across layers with the same collection and params, cleared on invalidation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loading a page in the builder canvas was slow when a collection is repeated across many component instances (common with reference collections). Each instance fired its own identical API request; on large collections these ran concurrently and saturated the event loop, making the canvas take a long time to load.
Changes
useCollectionLayerStore, keyed by the full request signature (collection + sort + limit + offset + filters)fetchLayerData) and post-edit refetch (refetchLayersForCollection)invalidateLayerData(per collection) andclearAllLayerData(all) so CMS edits and page switches still refetch fresh dataTest plan