fix: keep nested component links when resolving overrides#370
Merged
Conversation
An outer component pass could strip a valid link that was already resolved for a nested component instance, because resolution ran for any linked link variable regardless of scope. Only resolve when an override exists here or a matching variable is defined, leaving out-of-scope ids untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A nested component instance could lose its resolved link (e.g. the login/signup links in the Navigation component rendered without an
href) because an outer component override pass re-ran link resolution for link variables it didn't own and stripped them.Changes
applyComponentOverridesto the owning component: only resolve when an override exists for the variable in the current pass or a matching component variable is definedTest plan
href)href