Skip to content

MD5 checksum in Metadata#225

Merged
yorukot merged 5 commits into
yorukot:mainfrom
hyperionhex:main
Jun 3, 2024
Merged

MD5 checksum in Metadata#225
yorukot merged 5 commits into
yorukot:mainfrom
hyperionhex:main

Conversation

@hyperionhex

Copy link
Copy Markdown
Contributor

Added MD5 Checksum in metadata
superfile

Added MD5 Checksum in metadata
@netlify

netlify Bot commented May 31, 2024

Copy link
Copy Markdown

Deploy Preview for superfile ready!

Name Link
🔨 Latest commit b7cec0a
🔍 Latest deploy log https://app.netlify.com/sites/superfile/deploys/665dda4d51c69900082b7bb8
😎 Deploy Preview https://deploy-preview-225--superfile.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hyperionhex hyperionhex changed the title Update function.go MD5 checksum in Metadata May 31, 2024
@yorukot

yorukot commented May 31, 2024

Copy link
Copy Markdown
Owner

First of all, thank you very much for your contribution!!

I think this is a nice feature, but since MD5 generation actually consumes performance and slows down getting metadata, could you make it switchable in config.toml?

@yorukot

yorukot commented May 31, 2024

Copy link
Copy Markdown
Owner
  1. Add option on src/superfile_config/config.toml
  2. Add type on src/internal/config_type.go
  3. Add
if Config.MetadataMd5 {
// Get file MD5
}

@hyperionhex

Copy link
Copy Markdown
Contributor Author
  1. Add option on src/superfile_config/config.toml
  2. Add type on src/internal/config_type.go
  3. Add
if Config.MetadataMd5 {
// Get file MD5
}

Done

@hyperionhex hyperionhex left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Switchable MD5 Checksum

@yorukot yorukot merged commit 3f7f8df into yorukot:main Jun 3, 2024
@yorukot

yorukot commented Jun 3, 2024

Copy link
Copy Markdown
Owner

wow thanks so much for the quick update!

@hyperionhex

Copy link
Copy Markdown
Contributor Author

brother I have one more idea what do you think about this?

superfile

@oppZ

oppZ commented Jun 3, 2024

Copy link
Copy Markdown

I suggest adding a shortcut to add the checksum in the metadata. If I would like to check the checksum for one or two files, I wouldn't like it to add it for the whole session because of the performance issues.
Also, I suggest adding the sha256 checksum as this is the checksum type usually available along with linux .iso files.

I upvote the permissions

Great project btw

@yorukot

yorukot commented Jun 6, 2024

Copy link
Copy Markdown
Owner

I suggest adding a shortcut to add the checksum in the metadata. If I would like to check the checksum for one or two files, I wouldn't like it to add it for the whole session because of the performance issues. Also, I suggest adding the sha256 checksum as this is the checksum type usually available along with linux .iso files.

This is a great idea to me!

@hyperionhex

Copy link
Copy Markdown
Contributor Author

I'm working on creating a shortcut but it might take some time and should i make the permission switchable or just like a shortcut for single file?

@yorukot

yorukot commented Jun 6, 2024

Copy link
Copy Markdown
Owner

I think a single file is a good choice.

If you have any questions, please feel free to ask :)

@hyperionhex

Copy link
Copy Markdown
Contributor Author

I think a single file is a good choice.

If you have any questions, please feel free to ask :)

Yes sir

@oppZ

oppZ commented Jun 7, 2024

Copy link
Copy Markdown

The permissions is something that can be benefited from session wide as it is not an expensive operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants